Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that "Examples" work #4421

Closed
8 of 10 tasks
RiccardoRossi opened this issue Mar 13, 2019 · 17 comments
Closed
8 of 10 tasks

Ensure that "Examples" work #4421

RiccardoRossi opened this issue Mar 13, 2019 · 17 comments

Comments

@RiccardoRossi
Copy link
Member

RiccardoRossi commented Mar 13, 2019

@KratosMultiphysics/all please ensure that your "examples" in the corresponding repository work correctly with the release version (branch Release 7.0). This is crucial for things that enter in the release.

Please thick the corresponding box once it is done (and add new boxes/new poeple named to correct what i missed)

@RiccardoRossi RiccardoRossi added this to the Release 7.0 milestone Mar 13, 2019
@antonialarese
Copy link
Member

@RiccardoRossi particle_mechanics example is working fine with the branch release 7.0

@RiccardoRossi
Copy link
Member Author

thx @antonialarese

@rubenzorrilla
Copy link
Member

To what concerns the fluid_dynamics, only one example is not working. It should work as soon as discussion #4121 is closed.

@ipouplana
Copy link
Member

All examples in Poromechanics are working ;)

@rubenzorrilla
Copy link
Member

To what concerns the fluid_dynamics, only one example is not working. It should work as soon as discussion #4121 is closed.

@adityaghantasala modified how the periodic BCs are imposed in this particular case to make the failing test work.

@RiccardoRossi
Copy link
Member Author

@adityaghantasala why the example was not working? the BlockB&S should be able to do it correctly according to what we spoke before merging

@adityaghantasala
Copy link
Member

@RiccardoRossi this is solved now ... yes you are correct it should and is working properly.
it is because of this flag and if condition ... I solved it ... !!

builder_and_solver = KratosCFD.ResidualBasedBlockBuilderAndSolverPeriodic(self.linear_solver,

@RiccardoRossi
Copy link
Member Author

thx @adityaghantasala

@RiccardoRossi
Copy link
Member Author

@RiccardoRossi
Copy link
Member Author

(sorry i guess i pinged some people that already did the check in the list...be patient :-) )

@GuillermoCasas
Copy link
Member

@RiccardoRossi: I do not think SwimmingDEMApp goes into the release.

@GuillermoCasas
Copy link
Member

GuillermoCasas commented Mar 19, 2019

By the way, I just tried python3 kratos_run_all_benchmarks.py in kratos/kratos/test_examples and that does not run:

ImportError: No module named 'benchmarking'

Is that meant to be so?

@philbucher
Copy link
Member

@GuillermoCasas yes, the benchmarking-stuff was removed => #2769

@philbucher
Copy link
Member

I have not removed test_examples from the core yet, thx for the reminder

@loumalouomega
Copy link
Member

Mines are done

@RiccardoRossi
Copy link
Member Author

ping @philbucher @KlausBSautter @loumalouomega @AlejandroCornejo for Structural Mechanics

ping @maceligueta for DEM

@maceligueta
Copy link
Member

I just marked DEM. However, swimming DEM examples do not work. Referencing @GuillermoCasas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants