removing benchmarking folder

[philbucher]

I think that these files are quite outdated
Also I saw several times already that it confuses new users that try to get into Kratos

This is a suggestion, decision is up to you @KratosMultiphysics/technical-committee

[jcotela]

In principle the @KratosMultiphysics/technical-committee agrees with deleting this, but the benchmarking files are still used by the cases in the test_examples folders in each application. Most of these test examples are terribly outdated, though.

@KratosMultiphysics/team-maintainers Can each of us check the remaining test_examples cases in our applications? They should be either removed, converted to tests or updated and moved to the Examples repository.

If it is just a case of removing, I would push the changes to this branch.

[jcotela]

Applications with test examples folders to be updated:

• convection_diffusion_application
• FluidDynamicsApplication @jcotela
• incompressible_fluid_application @jcotela
• MeshingApplication @loumalouomega?
• mpi_search_application @roigcarlo?
• OpenCLApplication @RiccardoRossi?
• structural_application @RiccardoRossi?
• swimming_dem_application @maceligueta @GuillermoCasas
• ThermoMechanicalApplication @jcotela
• trilinos_application

[loumalouomega]

At least my test_examples are not related with benchmarking

[jcotela]

@loumalouomega look for import benchmarking from within the test_examples folder. The hits are the scripts that should be updated.

[loumalouomega]

OK, sorry for the noise

[RiccardoRossi]

the convection diffusion application has some bfecc benchmarks that should be working and need to be eventually ported...i would like to ask not to remove those until they are ported

[philbucher]

@RiccardoRossi I checked the bfecc benchmarks, they are not related to the benchmarking

There are however some test_examples in the convdiffapp that are using the benchmarking, should those be removed?

[philbucher]

ping @roigcarlo @maceligueta @GuillermoCasas

ping @jcotela regarding the incompressible_fluid_app

also ping @RiccardoRossi what abt the benchmarks in the structural_application and the OpenCLApplication?

[roigcarlo]

Test in the mpi_search_application is totally outdated, you can remove it safely

[philbucher]

@roigcarlo as requested I removed the folder test_examples from the mpi_search_application

[philbucher]

ping @maceligueta @GuillermoCasas

ping @jcotela regarding the incompressible_fluid_app

also ping @RiccardoRossi what abt the benchmarks in the structural_application and the OpenCLApplication?

[RiccardoRossi]

openclapplication can be removed completely

structural_application is pure legacy to me, same as for incompressible_fluid...i simply would not touch them and let the mantainers @vryy @Juliomarti to eventually fix/remove old stuff

[RiccardoRossi]

openclapplication can be removed completely

structural_application is pure legacy to me, same as for incompressible_fluid...i simply would not touch them and let the mantainers @vryy @Juliomarti to eventually fix/remove old stuff

[philbucher]

thanks @RiccardoRossi

I would say we can go ahead with this

If you give me a go then I can remove the OpenCLApp in a separate PR

[RiccardoRossi]

+1 for removing opencl (go!)

…

On Fri, Oct 12, 2018, 10:49 AM Philipp Bucher ***@***.***> wrote: thanks @RiccardoRossi <https://github.com/RiccardoRossi> I would say we can go ahead with this If you give me a go then I can remove the OpenCLApp in a separate PR — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2769 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHr7EUMlH6qqCuO70U96wY5IUCAYr1DPks5ukFeUgaJpZM4WUujd> .

[pooyan-dadvand]

Thanks for cleanup!! 👍