Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Geometries to entities modeler #11370
[Core] Geometries to entities modeler #11370
Changes from 34 commits
a3c9e13
22bf135
f4239a5
1ffea05
c1bb3f1
b8d8192
3ec860a
936d8c8
02783b8
11e0232
0b7e75e
344b056
5b7fe76
2046af2
f533030
38f1950
36bc13d
38717be
ba08fec
2cc9c6d
42e5f2f
54c2347
f5a3ea2
251c865
21ede17
604a4d9
097ce9a
0f08fab
2d43044
bc2c578
d30143c
70234b2
aa35d1d
54b6bfb
a26755f
4aa9245
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a warning? Isn't this why the function was made for? (Maybe should be
KRATOS_INFO_IF
).Imho warning should be if n_elements == 0.
Also you could merge both functions (see
LoopEntitiesList
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to inform the user that there are elements (entities) to be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same answer.