Fluid/feature python solver derivation #2262
Conversation
|
|
||
| self._SetUpRestart() | ||
|
|
||
| if self.load_restart: | ||
| self.restart_utility.LoadRestart() | ||
| restart_utility = self._GetRestartUtility() | ||
| restart_utility.LoadRestart() |
There was a problem hiding this comment.
this is in the baseclass now
Also I am writing a process for saving restarts atm such that one does not have to manually include it in each stage
There was a problem hiding this comment.
I think this will come in #2135? I'll update once that is merged, then.
| self._set_buffer_size() | ||
| self.main_model_part.SetBufferSize(self.min_buffer_size) | ||
|
|
||
| if not self.model.HasModelPart(self.settings["model_part_name"].GetString()): |
There was a problem hiding this comment.
this can be removed after the model is updated by riccardo
| self.main_model_part.AddNodalSolutionStepVariable(KratosMultiphysics.CONDUCTIVITY) | ||
| self.main_model_part.AddNodalSolutionStepVariable(KratosMultiphysics.SPECIFIC_HEAT) | ||
| self.main_model_part.AddNodalSolutionStepVariable(KratosFluid.HEAT_CAPACITY_RATIO) | ||
|
|
||
| self.main_model_part.AddNodalSolutionStepVariable(KratosMultiphysics.IS_STRUCTURE) ## ? | ||
| self.main_model_part.AddNodalSolutionStepVariable(KratosMultiphysics.BODY_FORCE) | ||
| self.main_model_part.AddNodalSolutionStepVariable(KratosMultiphysics.NODAL_H) ## ? | ||
| self.main_model_part.AddNodalSolutionStepVariable(KratosMultiphysics.NODAL_AREA) ## ? | ||
| self.main_model_part.AddNodalSolutionStepVariable(KratosMultiphysics.REACTION) #for momentum | ||
| self.main_model_part.AddNodalSolutionStepVariable(KratosFluid.REACTION_DENSITY) #for momentum |
There was a problem hiding this comment.
I'd take the chance to update the comments.
There was a problem hiding this comment.
To be honest, I think some of the marked variables may in fact be safely removed, but there is no test, so I didn't want to do it in this PR.
|
@rubenzorrilla I did it while you were reviewing, so github belives you approved it already... |
This makes the basic python solvers of the FluidDynamicsApplication derive from the PythonSolver class (that is, we bring the FluidDynamicsApplication up to date with #2068).
This is the initial phase for the cleanup of solvers missing from #871.
@rubenzorrilla I did not test the trilinos version of the Ausas solver (because I don't have any example ready), could you try this one? I think I have covered the rest.