Model v3 - third iteration of the model redesign #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it in the kernel" This reverts commit 001cf85.
…date Updating old format files to Model v3
…odel Adaptation to model of PfemFluid
|
@RiccardoRossi I updated a test I just merged, but it seems like the branch is not compiling, not sure why though (not my fault ;) ) |
roigcarlo
approved these changes
Oct 18, 2018
|
can you pls give me one sec, gotta check sth |
|
Ignasi, please do not merge this otherwise we will have to wait again for the Travis to compile Model_v3 we will merge this directly to master |
|
as discussed over the phone, please go ahead and merge, all good from my side |
|
thx @philbucher just done! |
|
👍 |
|
You made it!! 👍 |
|
|
armingeiser
added a commit
that referenced
this pull request
Oct 18, 2018
armingeiser
added a commit
that referenced
this pull request
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is third iteration of the model. It is now not registered in Kernel not it is a global object.
i would say that the design is pretty clean now (there is nothing strange in the model object, in the sense that it is NOT a singleton any longer)
the problem is that this change is backward incompatible in that it hides the modelpart. Modelpart can now ONLY be created through the model interface.
as of now, i ported all of the core, to the point at which all the tests pass (both python and c++).
If we go for this design i will need help in porting all of the applications