Apps/improve py init #3642
Merged
Apps/improve py init #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems like I messed up sth, fixing it now |
|
now it works, I had forgotten to rename some files |
There was a problem hiding this comment.
The changes look fine according to what was discussed ..!
@jcotela do you also agree with these changes ?
|
@adityaghantasala I discussed it briefly in person with @philbucher yesterday, but I think it makes a lot of sense. |
|
sorry for messing this up in the first place :/ |
jcotela
approved these changes
Dec 13, 2018
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates how the new python-init scripts are being used.
Initially I had put them into the python_scripts folder of the apps and named the
__init__.py, but this introduces the problem that then this folder can be imported as a python-modules, which should not be the case.Therefore I moved them back where they were initially and used the original name
=> CMake does the renaming now when installing the file to
KratosMultiphysics=> this way we can avoid all problems with the potentially dangerous
__init__.pyNOTE: this PR does not change the behavior, the apps still work as python-modules (introduced in #3217 )
sorry for the inconvenience
Wiki is updated