[ParticleMechanics] Python modules init #3689
Conversation
bodhinandach
added
Applications
FastPR
| @@ -1,5 +1,5 @@ | |||
| import KratosMultiphysics | |||
| import KratosMultiphysics.ParticleMechanicsApplication | |||
| import KratosMultiphysics.ParticleMechanicsApplication as KratosParticle | |||
There was a problem hiding this comment.
why do you change this? This is not related to the python modules
There was a problem hiding this comment.
This is just a minor cleanup, to make all the import called as KratosParticle. Not related yes.
There was a problem hiding this comment.
I checked the file, you are not using anything from the ParticlesApp there, therfore I recommend removing them (also codacy complains abt it being unused which is true)
I recommend to only import them if you need them
There was a problem hiding this comment.
we can discuss in person if you have questions
There was a problem hiding this comment.
I agree with you. In fact, I removed it from some other python files too. Thanks for the suggestion!
There was a problem hiding this comment.
It is not correct yet, I will explain it to you in person tmr
Nothing big, don't worry
| @@ -1,7 +1,7 @@ | |||
| from __future__ import print_function, absolute_import, division #makes KratosMultiphysics backward compatible with python 2.6 and 2.7 | |||
|
|
|||
| import KratosMultiphysics | |||
| import KratosMultiphysics.ParticleMechanicsApplication | |||
| import KratosMultiphysics.ParticleMechanicsApplication as KratosParticle | |||
| from particle_mechanics_analysis import ParticleMechanicsAnalysis | |||
There was a problem hiding this comment.
| from particle_mechanics_analysis import ParticleMechanicsAnalysis | |
| from KratosMultiphysics.ParticleMechanicsApplication.particle_mechanics_analysis import ParticleMechanicsAnalysis |
this is what became possible now with the python-modules
|
@philbucher can you recheck? |
| @@ -13,6 +12,7 @@ | |||
|
|
|||
| # Importing the base class | |||
| from analysis_stage import AnalysisStage | |||
There was a problem hiding this comment.
| from analysis_stage import AnalysisStage | |
| from KratosMultiphysics.analysis_stage import AnalysisStage |
|
One last thing then its ok If you find some more then you can fix them in later PRs |
|
Should I change all the import from KratosMultiphysics similarly, or just the analysis stage is fine? |
eventually yes, but for now it is ok |
Following #3217 and https://github.com/KratosMultiphysics/Kratos/wiki/Applications-as-python-modules for ParticleMechanics