[Core] adding functions to check if an app is available #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @roigcarlo |
roigcarlo
approved these changes
Jan 3, 2019
There was a problem hiding this comment.
👍
Sorry I missed the notification
Just a heads up, I have detected a bug with this code that happens when
1- You compile KratosCore, AppA, AppB
2- You compile KratosCore, AppB
You try to run/detect applications compiled, it detects A and B, while only B is up to date, which may cause errors.
Aside from that all good!
|
I mean, the same error is currently in the run_tests.py scrip, I just don't konow how to solve it yet. |
|
no worries, thx! The error you describe does not happen if the |
|
Yep its the same thing |
This was referenced Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful, at least I would like to use it :)
refactored from
run_tests.pyand #3562 , I can solve the conflicts there afterwards