Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor CMake cleanup and KratosMultiphysics install logic. #4314

Merged
merged 4 commits into from
Mar 1, 2019

Conversation

roigcarlo
Copy link
Member

A couple of changes to the CMakeFile:

  • Temporally removing the packaging as it was not working anyway. The aim is to enable it again in the new version
  • KratosMultiphysics folder has a custom install script now which deletes the folder on "make install" (not on configure) so changes in the python modules and old applications not compiled should no longer give problems.

This should fix #4296 and... another one, sorry don't remember the number (@philbucher is the one with the problem with the FluidDynamicsApplication from @armingeiser I think ?)

@roigcarlo roigcarlo requested review from philbucher and a team March 1, 2019 15:06
@jcotela
Copy link
Member

jcotela commented Mar 1, 2019

Should we remove libs/ too? I guess it should not be that much of a problem with the current setup, but we can still be keeping outdated .so files there.

@roigcarlo
Copy link
Member Author

roigcarlo commented Mar 1, 2019

@jcotela Done, but I will try it on win first in the rare case it decides to change the order of the commands for some reason.

@armingeiser
Copy link
Member

Yes it was #2848

Copy link
Member

@philbucher philbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, thx a lot @roigcarlo !

Copy link
Member

@jcotela jcotela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appveyor passed, looks like it should work in windows too 👍

@roigcarlo roigcarlo merged commit 9771a61 into master Mar 1, 2019
@roigcarlo roigcarlo deleted the core/minor-cmake-cleanup branch March 1, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[StructuralMechanicsApplication] kratos_utilities has no attribute CheckIfApplicationsAvailable
4 participants