[FluDyn] Embedded elements - fix issue in omp #6972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice catch @ddiezrod 🎉 |
|
@rubenzorrilla Is this ok for you? |
|
@roigcarlo I think this should also be ported to the release branch once merged |
rubenzorrilla
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found these errors running tests in FullDebug with Windows. It seems they do not arise usually in gcc.
I think this fixes #6431
(The original error @philbucher mentioned in
embedded_couette_test)Problem is that one thread could change the mData of the node while another thread is still finding if EMBEDDED_VELOCITY was present in the mData. This explains the strange error "difference between a singular iterator to a singular iterator."