Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log for when authconfig is de-indexed #426

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

adam-cattermole
Copy link
Member

Verification

Follow the user-guide up to step 9. to verify that there are no logs present when adding the disabled label.

Remove the disabled label from the AuthConfig:

kubectl -n myapp label authconfig/auth-config-2 disabled-

Update the authorino-production deployment to use an image built from this branch:

kubectl patch authorino/authorino-production --type=merge -p '{"spec":{"image":"quay.io/acatterm/authorino:log-deindex"}}'
kubectl rollout restart deployment authorino-production

Watch the logs:

kubectl logs -f $(kubectl get pods -l authorino-resource=authorino-production -o name)

Re-label the AuthConfig as disabled:

kubectl -n myapp label authconfig/auth-config-2 disabled=true

See a log stating the resource is de-indexed:

{"level":"info","ts":1695213540.451739,"logger":"authorino.controller-runtime.manager.controller.authconfig","msg":"resource de-indexed","authconfig":"myapp/auth-config-2"}

Resolves #423

@adam-cattermole adam-cattermole added kind/bug Something isn't working area/doc Improvements or additions to documentation participation/good first issue Good for newcomers area/implementation size/small target/current labels Sep 20, 2023
guicassolato
guicassolato previously approved these changes Sep 20, 2023
Copy link
Collaborator

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

didierofrivia
didierofrivia previously approved these changes Sep 20, 2023
@adam-cattermole
Copy link
Member Author

Just realised I should add the updated log line to the documentation - changed that in the latest commit

@adam-cattermole adam-cattermole merged commit c09056b into Kuadrant:main Sep 22, 2023
5 checks passed
@adam-cattermole adam-cattermole deleted the log-deindex branch September 22, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc Improvements or additions to documentation area/implementation kind/bug Something isn't working participation/good first issue Good for newcomers size/small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuthConfigs removed from the index are not reported in the logs
3 participants