[distributed storage] support re-syncing counters after a peer is partitioned. #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirino
changed the title
chirino
force-pushed
the
distributed-re-sync
branch
from
db635a9 to
9e88f5b
Compare
|
Trying to avoid doing too many re-sync on every connect to a peer, but I think we could end up in scenarios where you have peers A, B, C, D and |
…titioned. Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
chirino
force-pushed
the
distributed-re-sync
branch
from
9e88f5b to
0f45043
Compare
|
Switched to a more simplified strategy of syncing with every peer session. It should work better in the face of complex network partitions. |
alexsnaps
reviewed
May 23, 2024
* rewrote the inter_ourselfs_inner, we now avoid a full clone * remove unneeded clone of the limits. * avoid sending a re-sync counter if it has expired.
alexsnaps
approved these changes
May 24, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This likely needs more thought put into it. A peer only resyncs when it goes from having zero active connections to 1 active connection.