Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminListBundle] Change pagerfanta dependencies to require the minimum needed packages #2773

Merged
merged 1 commit into from
May 24, 2021

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Oct 1, 2020

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #2755

The white-october/pagerfanta-bundle package is not a required dependency for the cms, this will also make supporting symfony 5 easier. This PR also adds a BC layer to convert "old" WhiteOctober bundle config to the new bundle

TODO:

  • Create PR for cms skeleton to require babdev bundle
  • Test with projects requiring old bundle

@acrobat acrobat added this to the 5.7.0 milestone Oct 1, 2020
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat modified the milestones: 5.7.0, 5.8.0 Oct 12, 2020
@acrobat acrobat force-pushed the change-pagerfanta-dependencies branch 5 times, most recently from ad56f56 to 0806a65 Compare March 14, 2021 16:20
@acrobat acrobat force-pushed the change-pagerfanta-dependencies branch 11 times, most recently from 79ef95c to 4aba6ab Compare March 15, 2021 07:46
@acrobat acrobat modified the milestones: 5.8.0, 5.9.0 Mar 17, 2021
@acrobat acrobat force-pushed the change-pagerfanta-dependencies branch 3 times, most recently from fd5ec4f to 59d8085 Compare May 24, 2021 11:06
@acrobat acrobat force-pushed the change-pagerfanta-dependencies branch 2 times, most recently from e16a72c to 572c5b4 Compare May 24, 2021 11:23
@acrobat acrobat force-pushed the change-pagerfanta-dependencies branch from 572c5b4 to 60aa216 Compare May 24, 2021 11:25
@acrobat acrobat merged commit 9bea822 into Kunstmaan:master May 24, 2021
@acrobat acrobat deleted the change-pagerfanta-dependencies branch May 24, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AdminListBundle] Pagerfanta DoctrineORMAdapter is deprecated
3 participants