Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboardbundle] Rework dashboard command calls #2863

Merged
merged 1 commit into from
Apr 25, 2021
Merged

[Dashboardbundle] Rework dashboard command calls #2863

merged 1 commit into from
Apr 25, 2021

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Apr 11, 2021

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Fixed tickets fixes #2752

@acrobat acrobat added this to the 5.9.0 milestone Apr 11, 2021
ProfessorKuma
ProfessorKuma approved these changes Apr 11, 2021
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat force-pushed the fix-dashboard-bundle-deprecations branch from e45e73f to f69de5a Compare April 11, 2021 09:31
@acrobat acrobat force-pushed the fix-dashboard-bundle-deprecations branch 2 times, most recently from b553763 to 3efce8a Compare April 25, 2021 19:46
@acrobat acrobat force-pushed the fix-dashboard-bundle-deprecations branch from 3efce8a to a1efeba Compare April 25, 2021 20:02
@acrobat acrobat merged commit 5017f71 into Kunstmaan:master Apr 25, 2021
@acrobat acrobat deleted the fix-dashboard-bundle-deprecations branch April 25, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Type: Deprecation Type: Improvement
Projects
None yet
Milestone
5.9.0
Development

Successfully merging this pull request may close these issues.

[DashboardBundle] GoogleAnalyticsDataCollectCommand deprecation
2 participants
@acrobat @ProfessorKuma