[AdminBundle] New login styling #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dbeerten
commented
Jun 10, 2021
•
dbeerten
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets |
ProfessorKuma
suggested changes
Jun 10, 2021
There was a problem hiding this comment.
Hi @, your PR needs some changes
- Your answer if this PR is a bugfix seems to be incorrect.
- Your answer if this PR is a new feature seems to be incorrect.
- Your answer if this PR is BC breaking seems to be incorrect.
- Your answer if this PR is has deprecations seems to be incorrect.
- your PR title should look like
[SomeBundle] Fixed some code
acrobat
requested changes
Jun 13, 2021
| } | ||
| </style> #} | ||
|
|
||
| {# {% include "@KunstmaanAdmin/Default/_css_extra.html.twig" %}#} |
There was a problem hiding this comment.
Do we need to uncomment or remove this line? (and uncomment line 35?)
| @@ -0,0 +1,196 @@ | |||
| {# TODO: html template, teksten in translations #} | |||
| @@ -1,6 +1,9 @@ | |||
| {% extends '@KunstmaanAdmin/authentication/layout.html.twig' %} | |||
|
|
|||
| {% block login_content %} | |||
| <h2 class="app-login__form-title"> | |||
| Log in to {{ websitetitle | trans }} | |||
There was a problem hiding this comment.
We need to move this to a translation key
src/Kunstmaan/AdminBundle/Resources/views/authentication/login.html.twig
Show resolved
Hide resolved
| {% block login_footer %} | ||
| <footer class="app-login__footer"> | ||
| <p class="app-login__footer__text"> | ||
| <img src="/bundles/kunstmaanadmin/default-theme/img/kunstmaan/logo-cms-color.svg" class="app-login__footer__logo"> |
There was a problem hiding this comment.
Can you add the asset function around the image path?
| </header> | ||
|
|
||
| <figure class="app-login__image-holder"> | ||
| {% set login_image_url = '/bundles/kunstmaanadmin/default-theme/img/kunstmaan/default-login-bg.jpg' %} |
There was a problem hiding this comment.
Can you add the asset function around the image path?
src/Kunstmaan/AdminBundle/Resources/views/authentication/layout.html.twig
Outdated
Show resolved
Hide resolved
src/Kunstmaan/AdminBundle/Resources/views/authentication/layout.html.twig
Outdated
Show resolved
Hide resolved
ProfessorKuma
suggested changes
Jun 13, 2021
ProfessorKuma
approved these changes
Jun 13, 2021
acrobat
approved these changes
Jul 25, 2021
acrobat
added a commit
that referenced
this pull request
Jul 27, 2021
* master: [AdminBundle] Finish version checker deprecations [TranslatorBundle] Remove forced import from admin interface [TranslatorBundle] Remove incorrect deprecation, class will be renamed [AdminBundle] New login styling (#2888)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.