Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AllBundles] Fix branch alias of separate packages #2902

Merged
merged 1 commit into from
Jul 11, 2021
Merged

[AllBundles] Fix branch alias of separate packages #2902

merged 1 commit into from
Jul 11, 2021

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Jul 11, 2021

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

ProfessorKuma
ProfessorKuma suggested changes Jul 11, 2021
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • This PR seems to need a milestone of a minor release.

@ProfessorKuma ProfessorKuma added this to the 5.9.0 milestone Jul 11, 2021
ProfessorKuma
ProfessorKuma approved these changes Jul 11, 2021
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat merged commit f961be3 into Kunstmaan:master Jul 11, 2021
@acrobat acrobat deleted the fix-branch-alias branch July 11, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Type: Feature
Projects
None yet
Milestone
5.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@acrobat @ProfessorKuma