Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AllBundles] Allow and test against php 8 #2906

Merged
merged 3 commits into from
Sep 16, 2021
Merged

[AllBundles] Allow and test against php 8 #2906

merged 3 commits into from
Sep 16, 2021

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Jul 17, 2021 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

The temp commit needs to be removed when FriendsOfSymfony/FOSUserBundle#3006 is merged.

Blocked by:

@acrobat acrobat added this to the 5.9.0 milestone Jul 17, 2021
ProfessorKuma
ProfessorKuma suggested changes Jul 17, 2021
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • your PR title should look like [SomeBundle] Fixed some code

@acrobat acrobat changed the title Allow and test against php 8 [AllBundles] Allow and test against php 8 Jul 17, 2021
@acrobat acrobat marked this pull request as ready for review September 9, 2021 14:02
@acrobat acrobat linked an issue Sep 15, 2021 that may be closed by this pull request
PHP 8 Support #2853
Closed
@acrobat acrobat merged commit f2bb24e into Kunstmaan:master Sep 16, 2021
@acrobat acrobat deleted the php8-support branch September 16, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma requested changes

Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
5.9.0
Development

Successfully merging this pull request may close these issues.

PHP 8 Support
2 participants
@acrobat @ProfessorKuma