Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AllBundles] Migration path for controller extending deprecated controller class #2946

Merged
merged 1 commit into from
Sep 29, 2021
Merged

[AllBundles] Migration path for controller extending deprecated controller class #2946

merged 1 commit into from
Sep 29, 2021

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Sep 16, 2021 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Fixed tickets
  • Test in demo project

@acrobat acrobat added this to the 5.9.0 milestone Sep 16, 2021
ProfessorKuma
ProfessorKuma approved these changes Sep 16, 2021
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat linked an issue Sep 16, 2021 that may be closed by this pull request
Replace controller extends to AbstractController #2938
Closed
@acrobat acrobat force-pushed the prepare-controller-deprecation-changes branch 2 times, most recently from 4bb6656 to 7b675a2 Compare September 16, 2021 14:21
@acrobat acrobat force-pushed the prepare-controller-deprecation-changes branch 3 times, most recently from 3c075e9 to 3d2b84f Compare September 24, 2021 14:41
@acrobat acrobat marked this pull request as ready for review September 24, 2021 14:43
@acrobat acrobat force-pushed the prepare-controller-deprecation-changes branch 2 times, most recently from 5e1ea62 to 9177f4c Compare September 26, 2021 17:21
@acrobat acrobat force-pushed the prepare-controller-deprecation-changes branch from 9177f4c to 0e381ff Compare September 26, 2021 17:32
@acrobat acrobat merged commit a62d26f into Kunstmaan:master Sep 29, 2021
@acrobat acrobat deleted the prepare-controller-deprecation-changes branch September 29, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Numkil Numkil Numkil approved these changes

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Type: Deprecation Type: Improvement
Projects
None yet
Milestone
5.9.0
Development

Successfully merging this pull request may close these issues.

Replace controller extends to AbstractController
3 participants
@acrobat @Numkil @ProfessorKuma