Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeBundle] Deprecate SlugActionInterface and replace it by PageRender setup #2949

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Sep 24, 2021

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Fixed tickets

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat force-pushed the deprecate-slug-action branch 16 times, most recently from 80f255e to a541031 Compare September 26, 2021 15:37
@acrobat acrobat marked this pull request as ready for review September 26, 2021 15:40
docs/content-management/creating-a-pagetype.md Outdated Show resolved Hide resolved
docs/content-management/creating-a-pagetype.md Outdated Show resolved Hide resolved
UPGRADE-5.9.md Outdated Show resolved Hide resolved
@acrobat
Copy link
Member Author

acrobat commented Sep 27, 2021

@Numkil fixed!

Copy link
Contributor

@Numkil Numkil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@acrobat acrobat force-pushed the deprecate-slug-action branch 2 times, most recently from cd739a0 to 796c1fb Compare September 29, 2021 12:59
@acrobat acrobat merged commit 90e3dff into Kunstmaan:master Sep 29, 2021
@acrobat acrobat deleted the deprecate-slug-action branch September 29, 2021 13:08
@henrypenny
Copy link
Contributor

Is there any documentation on what to do with old projects that use SlugActionInterface extensively.
Not sure how you can justify saying : BC breaks? | no

@acrobat
Copy link
Member Author

acrobat commented Mar 30, 2023

@henrypenny There is some documentation on how to move forward in the UPGRADE-5.9 doc. We've replaced the old slugaction logic with the viewdataprovider and in a way they work exactly the same. This is also called before the view render in the slug controller and also the renderContext object is populated through that service. The only main difference is that this is not linked to a specific controller anymore but it exists as a separate service.

So far we didn't have a case in our upgrades (or got any other reports) that there are less possibilities with the new system in comparison with the old. So that's also the reason why "BC breaks - no" is in the PR. Existing 5.x applications continue to work and as far as we know the new system is an equal replacement.

If you still have cases that are not possible anymore, please open an issue or discussion to bring these things to our attention. From there we can see how these issues can be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants