-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NodeBundle] Deprecate SlugActionInterface and replace it by PageRender setup #2949
Conversation
acrobat
commented
Sep 24, 2021
Q | A |
---|---|
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | yes |
Fixed tickets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @, your PR passed all our requirements.
Thank you for contributing!
80f255e
to
a541031
Compare
cc0cdd1
to
7450714
Compare
7450714
to
323a46f
Compare
@Numkil fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
cd739a0
to
796c1fb
Compare
796c1fb
to
885db3c
Compare
Is there any documentation on what to do with old projects that use SlugActionInterface extensively. |
@henrypenny There is some documentation on how to move forward in the UPGRADE-5.9 doc. We've replaced the old slugaction logic with the viewdataprovider and in a way they work exactly the same. This is also called before the view render in the slug controller and also the renderContext object is populated through that service. The only main difference is that this is not linked to a specific controller anymore but it exists as a separate service. So far we didn't have a case in our upgrades (or got any other reports) that there are less possibilities with the new system in comparison with the old. So that's also the reason why "BC breaks - no" is in the PR. Existing 5.x applications continue to work and as far as we know the new system is an equal replacement. If you still have cases that are not possible anymore, please open an issue or discussion to bring these things to our attention. From there we can see how these issues can be resolved. |