Skip to content

Commit

Permalink
[UX] Add SF symbol for support section icon (#53)
Browse files Browse the repository at this point in the history
  • Loading branch information
Kyle-Ye authored Sep 1, 2023
1 parent 9d07fed commit 1d0ade9
Show file tree
Hide file tree
Showing 21 changed files with 1,539 additions and 23 deletions.
6 changes: 6 additions & 0 deletions Forumate/Other/Assets.xcassets/logo/Contents.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"info" : {
"author" : "xcode",
"version" : 1
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"info" : {
"author" : "xcode",
"version" : 1
},
"symbols" : [
{
"filename" : "discord.fill.svg",
"idiom" : "universal"
}
]
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"info" : {
"author" : "xcode",
"version" : 1
},
"symbols" : [
{
"filename" : "discourse.fill.svg",
"idiom" : "universal"
}
]
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"info" : {
"author" : "xcode",
"version" : 1
},
"symbols" : [
{
"filename" : "git.pullrequest.svg",
"idiom" : "universal"
}
]
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"info" : {
"author" : "xcode",
"version" : 1
},
"symbols" : [
{
"filename" : "github.fill.svg",
"idiom" : "universal"
}
]
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"info" : {
"author" : "xcode",
"version" : 1
},
"symbols" : [
{
"filename" : "logo.buymeacoffee.svg",
"idiom" : "universal"
}
]
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"info" : {
"author" : "xcode",
"version" : 1
},
"symbols" : [
{
"filename" : "logo.git.fill.svg",
"idiom" : "universal"
}
]
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"info" : {
"author" : "xcode",
"version" : 1
},
"symbols" : [
{
"filename" : "logo.github.circle.fill.svg",
"idiom" : "universal"
}
]
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"info" : {
"author" : "xcode",
"version" : 1
},
"symbols" : [
{
"filename" : "twitter.svg",
"idiom" : "universal"
}
]
}
167 changes: 167 additions & 0 deletions Forumate/Other/Assets.xcassets/logo/twitter.symbolset/twitter.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
40 changes: 27 additions & 13 deletions Forumate/Other/Localizable.xcstrings
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,24 @@
"sourceLanguage" : "en",
"strings" : {
"" : {

"localizations" : {
"zh-Hans" : {
"stringUnit" : {
"state" : "translated",
"value" : ""
}
}
}
},
" " : {

"localizations" : {
"zh-Hans" : {
"stringUnit" : {
"state" : "translated",
"value" : ""
}
}
}
},
"%@" : {
"localizations" : {
Expand Down Expand Up @@ -243,7 +257,7 @@
}
}
},
"Discuss at Discourse Forum topic" : {
"Discuss at Discourse Forum Topic" : {
"localizations" : {
"zh-Hans" : {
"stringUnit" : {
Expand All @@ -253,16 +267,6 @@
}
}
},
"Discuss at Forumate Discord Server" : {
"localizations" : {
"zh-Hans" : {
"stringUnit" : {
"state" : "translated",
"value" : "加入 Forumate 的 Discord 服务器进行讨论"
}
}
}
},
"Error saving icon to Downloads folder." : {
"localizations" : {
"zh-Hans" : {
Expand Down Expand Up @@ -353,6 +357,16 @@
}
}
},
"Join Forumate Discord Server" : {
"localizations" : {
"zh-Hans" : {
"stringUnit" : {
"state" : "translated",
"value" : "加入 Forumate 的 Discord 社区"
}
}
}
},
"Mark as read" : {
"localizations" : {
"zh-Hans" : {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ struct IconSelectorSection: View {
showAlert = true
}
#else
Task {
_ = Task {
do {
let name = icon.rawValue == Icon.primary.rawValue ? nil : icon.appIconName
try await UIApplication.shared.setAlternateIconName(name)
Expand Down
17 changes: 9 additions & 8 deletions Forumate/View/Tab/Settings/Sections/SupportSection.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,45 +12,46 @@ struct SupportSection: View {
List {
Section {
Link(destination: URL(string: "https://github.com/Kyle-Ye/Forumate/issues/new?template=BUG_REPORT.yml")!) {
Label("Bug Report", systemImage: "link")
Label("Bug Report", image: "github.fill")
}
Link(destination: URL(string: "https://github.com/Kyle-Ye/Forumate/issues/new?template=FEATURE_SUGGESTION.yml")!) {
Label("Feature Suggestion", systemImage: "link")
Label("Feature Suggestion", image: "github.fill")
}
Link(destination: URL(string: "https://meta.discourse.org/t/forumate-native-discourse-client-for-ios")!) {
Label("Discuss at Discourse Forum topic", systemImage: "link")
Label("Discuss at Discourse Forum Topic", image: "discourse.fill")
}
Link(destination: URL(string: "https://discord.gg/ZHq5PzbGmE")!) {
Label("Discuss at Forumate Discord Server", systemImage: "link")
Label("Join Forumate Discord Server", image: "discord.fill")
}
} header: {
Text("Bug Report and Feature Suggestion")
}
Section {
Link(destination: URL(string: "https://github.com/Kyle-Ye/Forumate/issues/new?template=RECOMMEND_FORUM.yml")!) {
Label("Suggest new Recommend Forum item", systemImage: "link")
Label("Suggest new Recommend Forum item", image: "git.pullrequest")
}
Link(destination: URL(string: "https://github.com/Kyle-Ye/Forumate/issues/new?template=NEW_ICON.yml")!) {
Label("Contribute new App Icon", systemImage: "link")
Label("Contribute new App Icon", image: "git.pullrequest")
}
} header: {
Text("Contribute to Forumate project")
}
Section {
Link(destination: URL(string: "https://github.com/Kyle-Ye/Forumate")!) {
Label("Browse Forumate's source code", systemImage: "link")
Label("Browse Forumate's source code", image: "logo.git.fill")
}
} header: {
Text("Source Code")
}
Section {
Link(destination: URL(string: "https://twitter.com/ForumateApp")!) {
Label("Follow me on Twitter", systemImage: "link")
Label("Follow me on Twitter", image: "twitter")
}
} header: {
Text("Other")
}
}
.symbolRenderingMode(.multicolor)
}
}

Expand Down
2 changes: 1 addition & 1 deletion Forumate/View/Tab/Settings/SettingsTabRoot.swift
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ struct SettingsTabRoot: View {
}
} footer: {
Text(verbatim: """
\(AppInfo.name) v\(AppInfo.version) Build \(AppInfo.buildNumber)
\(AppInfo.name) v\(AppInfo.version)-beta Build \(AppInfo.buildNumber)
\(AppInfo.OSVersion)
""")
.multilineTextAlignment(.leading)
Expand Down

0 comments on commit 1d0ade9

Please sign in to comment.