Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress bar dont work for Russian characters #2451

Closed
Smoodust opened this issue Apr 10, 2023 · 2 comments · Fixed by #2539
Closed

Progress bar dont work for Russian characters #2451

Smoodust opened this issue Apr 10, 2023 · 2 comments · Fixed by #2539
Labels
bug Something isn't working UI/UX All website Components website

Comments

@Smoodust
Copy link

I was working on an annotation in Russian (writing user responses), and I noticed when I write Russian characters, the progress bar remains empty.
image
But if typed english word
image
Or digit
image
Progress bar starts to fill up.
@olliestanley olliestanley added bug Something isn't working website UI/UX All website Components labels Apr 11, 2023
@vivekpabari
Copy link
Contributor

I did some debugging on this issue. Here are my findings.

  • Progress Bar only detects the English language and does not depend on any selected language.
  • Reason there is the regex for word counting like this /\w+/g that only matches English characters.
  • This regex was added to resolve this issue #492
    I will try to resolve this issue. Please assign this issue to me.

vivekpabari added a commit to vivekpabari/Open-Assistant that referenced this issue Apr 15, 2023
@vivekpabari
LAION-AI#2451 - fix progress bar for all characters
dc33433
@vivekpabari
Copy link
Contributor

I have raised the PR Link. Please review it.

@AbdBarho AbdBarho linked a pull request Apr 15, 2023 that will close this issue
#2451 - fix progress bar for all characters #2539
Merged
AbdBarho pushed a commit that referenced this issue Apr 15, 2023
@vivekpabari
#2451 - fix progress bar for all characters (#2539)
97e118b 
Change regex to `/\S+/g` from `/\w+/g` to resolved issue
[#2451](#492)

`Screenshot:`

![image](https://user-images.githubusercontent.com/69248279/232235273-e3e92de9-8d8b-4143-bd7a-cb73984d7995.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working UI/UX All website Components website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2451 - fix progress bar for all characters vivekpabari/Open-Assistant
3 participants
@olliestanley @Smoodust @vivekpabari