Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat list scrollbar UI regression #3252

Closed
notmd opened this issue May 29, 2023 · 6 comments · Fixed by #3385
Closed

Chat list scrollbar UI regression #3252

notmd opened this issue May 29, 2023 · 6 comments · Fixed by #3385
Labels
bug Something isn't working UI/UX All website Components website

Comments

@notmd
Copy link
Collaborator

notmd commented May 29, 2023 •
edited
Loading

On dev
image
While on prod
image
Maybe related #3201
@notmd notmd added bug Something isn't working website good first issue Good issue for project newcomers UI/UX All website Components labels May 29, 2023
@notmd notmd changed the title Chat list scrollbar regression Chat list scrollbar UI regression May 29, 2023
@KarthikRaju391
Copy link
Contributor

Hi @notmd, I would like to help fix this bug but I didn't quite get what should be done. Can you please explain?

@notmd
Copy link
Collaborator Author

notmd commented May 29, 2023

Hi @KarthikRaju391 I mean the scrollbar UI is different, it should look like the second pic. You can check the UI on dev http://web.dev.open-assistant.io and compare with https://open-assistant.io. Make sure you are on Window.

@KarthikRaju391
Copy link
Contributor

@notmd, I'll be working on it. Thanks for letting me know.

@KarthikRaju391
Copy link
Contributor

chat.and.3.more.pages.-.Personal.-.Microsoft.Edge.2023-05-30.10-34-52.mp4

I think both the UIs are behaving the same @notmd

@KarthikRaju391
Copy link
Contributor

chat.-.Brave.2023-05-30.10-40-22.mp4

And the scrollbar is behaving differently in Brave browser...

@notmd
Copy link
Collaborator Author

notmd commented May 30, 2023

I think both the UIs are behaving the same @notmd

Hi, new version was deployed to prod yesterday, so both dev and prod have same UI although the scrollbar should like the second pic like I said. It should also look the same as the chat config's scrollbar
image

@andreaskoepf andreaskoepf moved this from 📫 Triage to 🛠 Todo in Open-Assistant Jun 11, 2023
@github-project-automation github-project-automation bot moved this to 📫 Triage in Open-Assistant Jun 11, 2023
@andreaskoepf andreaskoepf removed the good first issue Good issue for project newcomers label Jun 11, 2023
@notmd notmd closed this as completed Jun 11, 2023
@github-project-automation github-project-automation bot moved this from 🛠 Todo to ✅ Done in Open-Assistant Jun 11, 2023
@notmd notmd reopened this Jun 11, 2023
@github-project-automation github-project-automation bot moved this from ✅ Done to 📫 Triage in Open-Assistant Jun 11, 2023
@notmd notmd mentioned this issue Jun 11, 2023
Merged
AbdBarho pushed a commit that referenced this issue Jun 11, 2023
@notmd
Fix chat list double scrollbar (#3385)
1c50662 
Close #3252
- Dont render scrollbar in /chat page anymore.
- Fix an overflow bug in the chat list

I have manually verified all the UI
@github-project-automation github-project-automation bot moved this from 📫 Triage to ✅ Done in Open-Assistant Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working UI/UX All website Components website
Projects
Open-Assistant
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix chat list double scrollbar LAION-AI/Open-Assistant
3 participants
@andreaskoepf @notmd @KarthikRaju391