Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chat deletion confirmation gets covered by chat response #3267

Closed
wuhei opened this issue May 31, 2023 · 6 comments · Fixed by #3383
Closed

chat deletion confirmation gets covered by chat response #3267

wuhei opened this issue May 31, 2023 · 6 comments · Fixed by #3383
Assignees
@CertifiedJoon
Labels
bug Something isn't working UI/UX All website Components website

Comments

@wuhei
Copy link

wuhei commented May 31, 2023

image
@notmd notmd added bug Something isn't working website good first issue Good issue for project newcomers UI/UX All website Components labels May 31, 2023
@JaynouOliver
Copy link

Can I work on it? Please assign it to me.

@olliestanley
Copy link
Collaborator

Can I work on it? Please assign it to me.

Feel free to take a look, I have assigned you

@olliestanley olliestanley mentioned this issue Jun 6, 2023
Closed
@davidak
Copy link

davidak commented Jun 6, 2023

I can reproduce this issue. The dialog appears behind the chat. Also, the chat UI does not get darker.

Screenshot from 2023-06-06 10-30-58

@Maxuvious Maxuvious mentioned this issue Jun 8, 2023
Closed
@andreaskoepf andreaskoepf moved this from 📫 Triage to ⚙ In Progress in Open-Assistant Jun 9, 2023
@github-project-automation github-project-automation bot moved this to 📫 Triage in Open-Assistant Jun 9, 2023
@andreaskoepf
Copy link
Collaborator

@JaynouOliver Were you able to set up a dev environment and reproduce the problem?

@CertifiedJoon
Copy link
Contributor

@andreaskoepf If @JaynouOliver is struggling to fix it, I think I can take over. I have been working on delete feature on #3378 and #3306.

@andreaskoepf
Copy link
Collaborator

andreaskoepf commented Jun 11, 2023 •
edited
Loading

I think I can take over.

Since we haven't heard back from @JaynouOliver I transfer the issue over to you @CertifiedJoon. Thank you very much for helping to fix this!

@andreaskoepf andreaskoepf removed the good first issue Good issue for project newcomers label Jun 11, 2023
@CertifiedJoon CertifiedJoon mentioned this issue Jun 11, 2023
Merged
@github-project-automation github-project-automation bot moved this from ⚙ In Progress to ✅ Done in Open-Assistant Jun 13, 2023
notmd added a commit that referenced this issue Jun 13, 2023
@CertifiedJoon @notmd
Bug Fix: Delete feature (Fixes three issues) (#3383)
1f0113f 
Fixes: #3267 
Fixes: #3306 
Fixes: #3378 

Regarding: #3267 
Some of the z-indices were manged by zIndex parameter, while other
components where managed by Portals. Somehow the two conflicted and
created a weird mix of zIndices. I have changed popover's portal into
simple zindex parameter and parents, sibligns, and cousins accordingly.

Regarding: #3306 
The redirection to deleted chat happened because one of its parent
elements were a Link component. Previously, upon pressing delete,
stopEvent() was called to temporarily pause redirection, and redirection
would resume after the delete process. I have changed the Link component
into normal button with onClick redirection, maintaining the
stopPropogation behavior.

Regarding: #3378 
The default behavior of AlertDialog would wrap the text. But somehow
using portal on it would restrict text-wrap behavior. The text-wrap
behavior came back after removal of portal while working on #3267 .

deleting from /chat/{id}
<img width="1466" alt="image"
src="https://github.com/LAION-AI/Open-Assistant/assets/61619422/7faa1895-7894-41c3-ab57-5489db942641">

deleting from /chat
<img width="1440" alt="image"
src="https://github.com/LAION-AI/Open-Assistant/assets/61619422/d7b4494f-02f4-4953-bcd3-bf1c25de3b8f">

toast on delete
<img width="368" alt="image"
src="https://github.com/LAION-AI/Open-Assistant/assets/61619422/6ed228f1-64d3-4169-9657-aaff4e97ce06">

---------

Co-authored-by: notmd <notmd1811@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CertifiedJoon CertifiedJoon

Labels
bug Something isn't working UI/UX All website Components website
Projects
Open-Assistant
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug Fix: Delete feature (Fixes three issues) CertifiedJoon/Open-Assistant
7 participants
@davidak @olliestanley @andreaskoepf @wuhei @notmd @CertifiedJoon @JaynouOliver