Fix custom preset display #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmd
force-pushed
the
fix_custom_preset_display
branch
from
06dd333 to
a034ac0
Compare
notmd
force-pushed
the
fix_custom_preset_display
branch
from
a034ac0 to
f84ae07
Compare
notmd
commented
Apr 15, 2023
| @@ -24,12 +24,11 @@ export const WorkParametersDisplay = memo(function WorkParametersDisplay({ | |||
| parameters: NonNullable<InferenceMessage["work_parameters"]>; | |||
| }) { | |||
| const { seed: _, ...rest } = parameters; | |||
| const model_id = parameters.model_config.model_id; | |||
| const model_id = parameters.model_config.model_id.replace("OpenAssistant/", ""); | |||
There was a problem hiding this comment.
I also remove the prefix here
There was a problem hiding this comment.
this is only for display, correct?
|
Tbh I think hiding the preset would make more sense. Since we don't have enough information to show the correct preset. Yannic just make the change to |
|
makes sense, can we remove the preset and model name entirely? there is only one model anyway... |
|
@AbdBarho I remove the preset, still keep the model for now. We might need that in future, because the Pythia is coming |
AbdBarho
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2544
The problem is the
model_idinwork_parametersis not the same as the name inModelInfo. So I assume all models have the same preset config.