Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added "current announcement" to web (minimal implementation) #2571

Merged
merged 2 commits into from
Apr 16, 2023
Merged

Added "current announcement" to web (minimal implementation) #2571

merged 2 commits into from
Apr 16, 2023

Conversation

yk
Copy link
Collaborator

@yk yk commented Apr 16, 2023

No description provided.

@yk yk enabled auto-merge (squash) April 16, 2023 00:35
andreaskoepf
andreaskoepf approved these changes Apr 16, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, btw .. what happend to our maintenance mode page ... was that ever complete? ;-)..

@yk
Copy link
Collaborator Author

yk commented Apr 16, 2023

cool, btw .. what happend to our maintenance mode page ... was that ever complete? ;-)..

I really don't remember...

notmd
notmd reviewed Apr 16, 2023
View reviewed changes
Copy link
Collaborator

@notmd notmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initialShowAnnouncement is really nice

@yk yk merged commit b4895f4 into main Apr 16, 2023
@yk yk deleted the current-announcement branch April 16, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmd notmd notmd approved these changes

@andreaskoepf andreaskoepf andreaskoepf approved these changes

@AbdBarho AbdBarho Awaiting requested review from AbdBarho AbdBarho is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yk @andreaskoepf @notmd