Only fetch stats for logged in users #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdBarho
changed the title
notmd
reviewed
Apr 16, 2023
| if (!token.backendUserId) { | ||
| // user has not yet accepted the terms of service, and therefor does not yet exist in the backend | ||
| /// skip the request entirely | ||
| return res.status(200).json(null); |
There was a problem hiding this comment.
No it should not, the leaderboard will be empty.
It is also not visble since the ToS wrapper covers the entire screen, after the user accepts ToS the webpage is refreshed and a new request is made.
Another option we can do is send 404 and let useSWR retry. We then know that this is expected.
notmd
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2569
I will have to check in the console after deployment to see if it actually fixes the problem, but it worked on my local setup.