Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused npm dependencies from website #2626

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Conversation

lgeiger
Copy link
Contributor

@lgeiger lgeiger commented Apr 16, 2023

This PR removes a few unused npm dependencies from the website requirements.

@lgeiger lgeiger requested review from AbdBarho and notmd as code owners April 16, 2023 19:13
@@ -62,7 +60,6 @@
"next-auth": "^4.20.1",
"next-i18next": "^13.2.2",
"nodemailer": "^6.9.1",
"npm": "^9.6.2",
Copy link
Contributor Author

@lgeiger lgeiger Apr 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm is meant to be installed globally so there is no need to include it in package.json

"autoprefixer": "^10.4.14",
"axios": "^1.3.4",
"boolean": "^3.2.0",
"chart.js": "^4.2.1",
"clsx": "^1.2.1",
"cookies": "^0.8.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency was added in #1893 but appears to be unused now.

@@ -42,13 +42,11 @@
"@prisma/client": "^4.11.0",
"@tailwindcss/forms": "^0.5.3",
"@tanstack/react-table": "^8.8.2",
"accept-language-parser": "^1.5.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency was added in #881 but appears to be unused now.

Copy link
Collaborator

@notmd notmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you resolve the conflict?

@notmd notmd enabled auto-merge (squash) April 16, 2023 23:34
@notmd notmd merged commit 2d619b9 into LAION-AI:main Apr 16, 2023
@lgeiger lgeiger deleted the cleanup-npm branch April 16, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants