⬆️ storybook@7 #2629
Merged
⬆️ storybook@7 #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgeiger
commented
Apr 16, 2023
Comment on lines
-22
to
-28
| // fix to make absolute imports working in storybook | ||
| webpackFinal: async (config, { configType }) => { | ||
| config.resolve.alias = { | ||
| ...config.resolve.alias, | ||
| src: path.resolve(__dirname, "../src"), | ||
| styles: path.resolve(__dirname, "../styles"), | ||
| }; |
There was a problem hiding this comment.
This is not needed anymore as storybook now works with next.js automatically.
| @@ -114,8 +112,10 @@ | |||
| "jest-environment-jsdom": "^29.5.0", | |||
| "msw": "^0.49.3", | |||
| "msw-storybook-addon": "^1.8.0", | |||
| "path-browserify": "^1.0.1", | |||
There was a problem hiding this comment.
We already use this in website/.storybook/main.js so it makes sense to explicitly add this to the dev dependencies.
| "@testing-library/jest-dom": "^5.16.5", | ||
| "@testing-library/react": "^13.4.0", | ||
| "@types/accept-language-parser": "^1.5.3", | ||
| "@types/node": "^18.15.10", | ||
| "@types/react": "18.0.26", | ||
| "@types/react-syntax-highlighter": "^15.5.6", | ||
| "@typescript-eslint/eslint-plugin": "^5.56.0", | ||
| "assert": "^2.0.0", |
There was a problem hiding this comment.
This is required since webpack 5 (the default in storybook v7) doesn't include a polyfill for assert by default anymore.
notmd
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates storybook to version 7 following their migration guide to fix #1400.