Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracted shared python code and made it work with dockerfiles #39

Merged
merged 7 commits into from
Dec 19, 2022
Merged

Extracted shared python code and made it work with dockerfiles #39

merged 7 commits into from
Dec 19, 2022

Conversation

yk
Copy link
Collaborator

@yk yk commented Dec 19, 2022 •
edited
Loading

Extracts shared python code to oasst-shared with package oasst_shared.
Caveat is, users must pip install -e . inside the oasst-shared directory in order to be able to import it. Dockerfiles are adjusted to work out of the box.

@yk yk marked this pull request as ready for review December 19, 2022 18:15
@yk yk requested a review from andreaskoepf as a code owner December 19, 2022 18:15
andreaskoepf
andreaskoepf approved these changes Dec 19, 2022
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, like the new structure!

@andreaskoepf andreaskoepf merged commit 668c71d into main Dec 19, 2022
@andreaskoepf andreaskoepf deleted the extract-shared-python-code branch December 19, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskoepf andreaskoepf andreaskoepf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yk @andreaskoepf