Docker builds #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
palp
commented
Dec 14, 2022
palp
commented
- Add dockerfile for bot
- Add build actions for docker images (bot + backend)
|
do we need to build & publish on every push? Do you think it makes sense to restrict it to tags starting with "v", which would then be our releases? |
Yeah, every push is probably too much. PR builds might be useful for testing, but also probably a lot of noise. I'll set it up to work off tags for now and we can adjust if needed. |
|
I left in the path filters, which should skip "empty" releases (i.e., only the bot was modified, so no new image is built of the backend). This may or may not make sense to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.