Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fit): add sample_weight #7

Merged
merged 5 commits into from
Feb 3, 2021

Conversation

tczhao
Copy link
Contributor

@tczhao tczhao commented Feb 1, 2021

Added sample_wegith to .fit()

Thanks for the fantastic work.

I found that half of the sample_weight is implemented but not expose to the final fit API.

The sample_weight can make a big difference (90% -> 95%) despite the surprising stablity of the deep forest on skewed classification.

@xuyxu
Copy link
Member

xuyxu commented Feb 1, 2021

Thanks for the PR @tczhao. I will take a look latter ;-)

In addition, how about adding two things in your PR?

  • Numpy style docstrings below the function fit
  • Your contribution and name in CHANGELOG.rst. I think the corresponding badge should be Feature.

I will stay tuned, and let me if you have any problem.

@tczhao tczhao force-pushed the feature/add-sample_weight branch 2 times, most recently from d198b3c to cfefaa7 Compare February 1, 2021 16:04
@xuyxu
Copy link
Member

xuyxu commented Feb 2, 2021

Great, we are close to the merge! I will check the entire workflow and merge this PR if there is no problem. Thanks for your nice codes!

@xuyxu xuyxu merged commit 5e80183 into LAMDA-NJU:master Feb 3, 2021
@xuyxu
Copy link
Member

xuyxu commented Feb 3, 2021

Merged, thanks for your nice codes @tczhao ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants