Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hydropathy and depth scales #35

Merged
merged 11 commits into from
Mar 30, 2023
Merged

Update hydropathy and depth scales #35

merged 11 commits into from
Mar 30, 2023

Conversation

jvsguerra
Copy link
Member

  • Update depth colorbar
    • new ggplot2
    • add inline CSS
  • Update hydropathy colorbar
    • add inline CSS
    • remove PNG
    • remove padding from SVG file
  • Fix & conditionals in kvfinder-web-portal/R/mod_server_submitJob.R
  • Add warning emoji to submission message
  • Add cavity naming convention to Help page

@jvsguerra jvsguerra added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Mar 28, 2023
@jvsguerra jvsguerra self-assigned this Mar 28, 2023
helder-ribeiro
helder-ribeiro reviewed Mar 30, 2023
View reviewed changes
Copy link
Member

@helder-ribeiro helder-ribeiro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the old syntax in 'Fix conditionals' for now and we can change it later

@jvsguerra
Copy link
Member Author

Let's keep the old syntax in 'Fix conditionals' for now and we can change it later

To implement this decision, we have removed the commit with hash d2d247ba3ce8d13b0e8f3de18bca39a1cbda959c from the branch using the git rebase -i command."

@jvsguerra jvsguerra merged commit 9878000 into LBC-LNBio:dev Mar 30, 2023
@jvsguerra jvsguerra mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helder-ribeiro helder-ribeiro helder-ribeiro left review comments

@zgcarvalho zgcarvalho Awaiting requested review from zgcarvalho

Assignees

@jvsguerra jvsguerra

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvsguerra @helder-ribeiro