Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic linting #1310

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mrvisscher
Copy link
Collaborator

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@coveralls
Copy link

Coverage Status

coverage: 56.101%. remained the same
when pulling 731fb91 on mrvisscher:ruff-linting
into ee24c15 on LCA-ActivityBrowser:main.

@coveralls
Copy link

Coverage Status

coverage: 56.101%. remained the same
when pulling 5d5eefb on mrvisscher:ruff-linting
into ee24c15 on LCA-ActivityBrowser:main.

@coveralls
Copy link

Coverage Status

coverage: 56.101%. remained the same
when pulling 3f47570 on mrvisscher:ruff-linting
into ee24c15 on LCA-ActivityBrowser:main.

@coveralls
Copy link

Coverage Status

coverage: 56.101%. remained the same
when pulling 935b0a6 on mrvisscher:ruff-linting
into ee24c15 on LCA-ActivityBrowser:main.

Copy link
Contributor

@jsvgoncalves jsvgoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding a pre-commit [1] hook for ruff [2], to avoid wasting time (both from a devex and CI perspective).

[1] - https://pre-commit.com/
[2] - https://github.com/astral-sh/ruff-pre-commit?tab=readme-ov-file#using-ruff-with-pre-commit

Comment on lines +9 to +10
with:
args: check --fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with:
args: check --fix

Probably don't want to fix on CI, but on the pre-commit hook maybe?

Btw it's a good idea to set your editor (and CI) to ensure files end with a \n [1].

[1] - https://stackoverflow.com/a/729795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants