Bwutils tweaks #236
Bwutils tweaks #236
Conversation
|
|
||
| Class adapted from bw2calc.multi_lca.MultiLCA to include also CONTRIBUTION ANALYSIS. | ||
| Attributes |
There was a problem hiding this comment.
this is still quite incomplete. Best introduce also the different vectors and matrices that are used for storing the LCA results (e.g. process contributions); and also the indexing dictionaries
There was a problem hiding this comment.
Have just added all of the attributes of the class. It kind of feels like the comments in the init method are superfluous now.
| self.technosphere_flows = dict() | ||
| # Life cycle inventory (biosphere flows) by functional unit | ||
| self.inventory = dict() | ||
| # Inventory (biosphere flows) by activity (e.g. 2000x15000) and functional unit. |
There was a problem hiding this comment.
for a specific functional unit and LCIA method
| """Contribution Analysis built on top of the Multi-LCA class.""" | ||
| """Contribution Analysis built on top of the Multi-LCA class. | ||
|
|
||
| This class requires instantiated MLCA and MetaDataFrame objects. |
There was a problem hiding this comment.
what is the right name now MetaDataFrame or MetaDataStore ? I have seen both now :-)
There was a problem hiding this comment.
Whoops, you're right, have been using them interchangeably, will correct to MetaDataStore.
|
|
||
| This class does not subclass the `LCA` class, and performs all calculations upon instantiation. | ||
| Class adapted from bw2calc.multi_lca.MultiLCA to include also | ||
| CONTRIBUTION ANALYSIS. |
There was a problem hiding this comment.
perhaps write something like this "process and elementary flow contributions and other LCA results (see attributes below)"
came across this as we also implement our own contribution analysis class...
There was a problem hiding this comment.
How about:
This class is adapted from
bw2calc.multi_lca.MultiLCAand includes a
number of additional attributes required to perform process- and
elementary flow contribution analysis (see classContributionsbelow).
Add numpy-style docstrings to some of the classes in the
bwutilsdirectory which hopefully clarify the functionality.In addition, create new methods in the MetaDataStore class to encapsulate repeated code.
Finally, altered the
inventory_dfmethod, which used the reservedtypekeyword to useinventory_typeinstead. (which lead to small edits in code using that function).