Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor exchange table #271

Merged
merged 8 commits into from
Aug 23, 2019
Merged

Refactor exchange table #271

merged 8 commits into from
Aug 23, 2019

Conversation

dgdekoning
Copy link
Contributor

Replaces the activity exchange tables with QTableView classes using dataframes. All functionality is kept. Contains prep-work for parameterization.

Fixes at least part of #231

@dgdekoning dgdekoning requested a review from bsteubing August 23, 2019 09:50
@dgdekoning
Copy link
Contributor Author

dgdekoning commented Aug 23, 2019 •
edited
Loading

With these changes the old ExchangeTable code can be dropped entirely.

activity-browser/activity_browser/app/ui/tables/activity.py

Line 320 in 9bb7aef

class ExchangeTable(ABTableWidget):

@dgdekoning dgdekoning added the feature Issues/PRs related to a new feature label Aug 23, 2019
@coveralls
Copy link

coveralls commented Aug 23, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 44.643% when pulling ff929f4 on dgdekoning:refactor-exchange-table into ccdd948 on LCA-ActivityBrowser:master.

@dgdekoning dgdekoning merged commit c668083 into LCA-ActivityBrowser:master Aug 23, 2019
@dgdekoning dgdekoning deleted the refactor-exchange-table branch August 27, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsteubing bsteubing Awaiting requested review from bsteubing

Assignees
No one assigned
Labels
feature Issues/PRs related to a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgdekoning @coveralls