Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips in LCA Results #345

Merged
merged 4 commits into from
Dec 12, 2019
Merged

Tooltips in LCA Results #345

merged 4 commits into from
Dec 12, 2019

Conversation

marc-vdm
Copy link
Member

This PR adds tooltips to three sub-tabs in the LCA Results tab.
LCA Results: tooltips for the 'overview' and 'by LCIA method' buttons.
EF Contributions and Process contributions: tooltips for all options in cut-off menu and 'relative' and 'absolute' buttons.
The 'relative'/'absolute' buttons were moved left to give a more consistent view IMO.

Plot/Table, export buttons and the 'compare FU/IC' options were deemed clear enough.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 54.052% when pulling 06813c5 on e4BdSBmUzHowFico5Ktn:master into aa9f5a0 on LCA-ActivityBrowser:master.

@dgdekoning
Copy link
Contributor

Looks good! One thing I'd like to ask you to do is to change the descriptions from 'LCIA method' to 'Impact Category' (following #325).

@dgdekoning
Copy link
Contributor

Nice, I'll squash and merge after the tests go through. Thanks for adding the tooltips!

@dgdekoning dgdekoning merged commit 58b5530 into LCA-ActivityBrowser:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants