New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes and code cleanup #351

Merged

dgdekoning merged 3 commits into master from refactor-jan-2020

Jan 10, 2020

Contributor

dgdekoning commented Jan 10, 2020

This includes a user-friendliness fix to explain why a presamples calculation is failing.
Also included is a pin for the coverage version to ensure compatibility with python-coveralls.
Finally, a small cleanup to fold the HeaderTableTemplate class into the DatabaseWidget, it looks like the template class was initially going to be used for the ActitivityBiosphereWidget as well, but that ended up not happening?

dgdekoning added 3 commits

January 6, 2020 12:44


          Fold HeaderTableTemplate class into DatabaseWidget

77b7b9d


          Handle and explain an exception related to presample packages

ad52eca


          Pin lower version of coverage, due to breaking changes

b7307ce

See z4r/python-coveralls#73

coveralls commented Jan 10, 2020

Coverage decreased (-0.05%) to 54.044% when pulling b7307ce on refactor-jan-2020 into 4ded387 on master.

dgdekoning merged commit a355efc into master

dgdekoning deleted the refactor-jan-2020 branch

January 10, 2020 15:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet