Updates for NML v2.3 #112
Merged
Updates for NML v2.3 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix/pyneuroml 100
Development->exp
* master: Typos in parameter descriptions
* development: Typos in parameter descriptions To v0.10.7
Feat: Allow `reportFile` to use `__SIMULATOR__` and `__TIMESTAMP__` placeholders
Test on java 19
TODO: is a `class` different from `ComponentType`? If yes, this needs to be clarified somewhere to prevent confusion.
TODO: uses `type` in doc. Is that the same as `class` and/or `ComponentType`?
Needs checking: does it break anything?
Lots of minor doc updates
…mensions chore(LemsClasses): remove `Component` from `unitsdimensions`
Feat/annotate meta
... otherwise it errors saying that `Record` is ambiguous.
Command to regenerate: ``` $ mvn clean install # if changes made to generator $ java -classpath target/jlems-0.10.7.jar org.lemsml.jlems.io.reader.LemsFactoryGenerator.main ```
... since it cannot be instantiated (java throws error).
Annotate meta + add it as children of Simulation
Meta annotation updates
To v0.10.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly updates to the documentation for the various classes in the source, which will propagate to the main LEMS docs.
Allows
__SIMULATOR__and__TIMESTAMP__in report files.