Feature/lit 3041 js sdk cherry pick fixes for session key mismatch 443#issuecomment 2082614246

[Ansonhkg]

Description

New Implementation suggested here:
#443 (comment)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A
• Test B

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[MaximusHaximus]

Added a couple of things in-line :)

Also, IIRC, in order to fix the original issue we need to pass sessionKey into the params passed into getSessionSigs() on L210 also; the bug was that both getSessionSigs() and signSessionKey() would generate new keys when localstorage didn't exist and they would be different.

[MaximusHaximus]

👍 I think this is good to go 💖

[DashKash54]

LGTM!