Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add local storage provider option and test for expired sesson signature #672

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

joshLong145
Copy link

Description

Adds a test for asserting a session which has Ella-sped its expiration should throw a validation exception when attempting to use the expired session for network operations.

Adds a USE_STORAGE and STORAGE_LOCATION flags to tinny as to configure the storage provider which has been enabled for ci runs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules


if (res.isValid) {
throw new Error(
'Session signature validation should fail with expiration ellapsed'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word ellapsed is misspelled in the error message. Consider changing it to elapsed to maintain consistency with the function name and improve readability. This small correction will enhance the overall quality and professionalism of the code.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@joshLong145 joshLong145 changed the title add local storage provider optiion and test for expired sesson signature add local storage provider option and test for expired sesson signature Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant