Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cyclic dependency involving wasm-bindgen #3

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

mlafeldt
Copy link
Contributor

This PR fixes a dependency issue when updating Deno in our main repo and is required to unblock the update.

error: cyclic package dependency: package `getrandom v0.2.12` depends on itself. Cycle:
package `getrandom v0.2.12`
    ... which satisfies dependency `getrandom = "^0.2.7"` (locked to 0.2.12) of package `ahash v0.8.11`
    ... which satisfies dependency `ahash = "^0.8.6"` (locked to 0.8.11) of package `hashbrown v0.14.3`
    ... which satisfies dependency `hashbrown = "^0.14.1"` (locked to 0.14.3) of package `indexmap v2.2.6`
    ... which satisfies dependency `indexmap = "^2.2.1"` (locked to 2.2.6) of package `serde_json v1.0.115`
    ... which satisfies dependency `serde_json = "^1.0"` (locked to 1.0.115) of package `wasm-bindgen v0.2.92`
    ... which satisfies dependency `wasm-bindgen = "^0.2.92"` (locked to 0.2.92) of package `js-sys v0.3.69`
    ... which satisfies dependency `js-sys = "^0.3"` (locked to 0.3.69) of package `getrandom v0.2.12`
    ... which satisfies dependency `getrandom = "^0.2"` (locked to 0.2.12) of package `rand_core v0.6.4`
    ... which satisfies dependency `rand_core = "^0.6"` (locked to 0.6.4) of package `crypto-common v0.1.6`
    ... which satisfies dependency `crypto-common = "^0.1.4"` (locked to 0.1.6) of package `aead v0.5.2`

See tkaitchuck/aHash#95 for more info.

@mlafeldt
Copy link
Contributor Author

@mikelodder7 @GTC6244 Thanks for the review! Could one of you also approve LIT-Protocol/lit-ecdsa-wasm-combine#6, which is the same fix for another crate? 🙏

@mlafeldt mlafeldt merged commit 222d9c1 into main Apr 24, 2024
5 checks passed
@mlafeldt mlafeldt deleted the fix-cyclic-dep branch April 24, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants