Add include/exclude extensions options #262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightlark
reviewed
Oct 18, 2024
Comment on lines
+434
to
+437
| if not entry.includeFileExts: | ||
| entry.includeFileExts = [] | ||
| if not entry.excludeFileExts: | ||
| entry.excludeFileExts = [] |
There was a problem hiding this comment.
I was debating if the check should happen in surfactant/filetypeid/id_extension.py -- but I think this is the only place that makes sense, since it needs to be able to exclude files by extension even if they were identified by something like magic bytes.
We could perhaps expand Exts to Extensions, though Ext is a common enough abbreviation.
There was a problem hiding this comment.
The only other thought I have about this is should we add a core config setting that lets a user set a default list of include/exclude file exts?
nightlark
reviewed
Oct 18, 2024
nightlark
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If merged this pull request will add options for having lists of file extensions to include and exclude. This resolves #239.
Proposed changes
Adds includeFileExts and excludeFileExts options to the configuration file which are lists of file extensions to forcibly include/exclude.