Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not assume file must exist after an open call #789

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

wangvsa
Copy link
Collaborator

@wangvsa wangvsa commented Jul 28, 2023

Fix for issue #776 :

unifyfs_fid_open function assumes the file must exist after the open call, it throws an error if it's not.
This is not true because a file may be opened without O_CREAT.
Fix: changed LOGERR to LOGDBG and modified some related comments.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Testing (addition of new tests or update to current tests)
  • Documentation (a change to man pages or other documentation)

Signed-off-by: Chen Wang <wangvsa@gmail.com>
@adammoody adammoody merged commit 537301c into LLNL:dev Jul 31, 2023
6 checks passed
@adammoody
Copy link
Collaborator

Thanks, @wangvsa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants