Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doxygen on ReadTheDocs (+ return to srun for MPI tests on tioga) #1016

Merged
merged 12 commits into from
Feb 1, 2023

Conversation

bmhan12
Copy link
Contributor

@bmhan12 bmhan12 commented Jan 30, 2023

This PR:

@bmhan12 bmhan12 added CI Issues related to continuous integration Documentation Issues related to documentation labels Jan 30, 2023
Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmhan12 !

# Modify Doxyfile for ReadTheDocs compatibility
with open('./docs/doxygen/Doxyfile.in', 'r') as f:
fdata = f.read()
fdata = fdata.replace('@PROJECT_SOURCE_DIR@', '.')
with open('./docs/doxygen/Doxyfile.in', 'w') as f:
f.write(fdata)
with open('./docs/doxygen/Doxyfile.in', 'a') as f:
f.write("\nOUTPUT_DIRECTORY=./_build/html/doxygen")
f.write("\nOUTPUT_DIRECTORY=../_readthedocs/html/doxygen")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhornung67

This PR by ReadtheDocs introduced the change, and will likely impact most github projects using doxygen on ReadTheDocs:
readthedocs/readthedocs.org#9888

Doxygen generation broken in latest RAJA:
https://raja.readthedocs.io/en/develop/doxygen/html/index.html

The breaking change in their PR was renaming the hosted output directory from ./_build/html/... to ./_readthedocs/html/...

Seems like alot of projects are dependent on this _build directory:
https://github.com/search?q=filename%3Aconf.py+doxygen+%26%26+_build&type=Code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmhan12 Thanks for pointing this out.

@bmhan12 bmhan12 merged commit 19af5ad into develop Feb 1, 2023
@bmhan12 bmhan12 deleted the test/han12/doxyTree branch February 1, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues related to continuous integration Documentation Issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links to API documentations on github
3 participants