-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doxygen on ReadTheDocs (+ return to srun for MPI tests on tioga) #1016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bmhan12 !
a5d65cb
to
65d0b7c
Compare
# Modify Doxyfile for ReadTheDocs compatibility | ||
with open('./docs/doxygen/Doxyfile.in', 'r') as f: | ||
fdata = f.read() | ||
fdata = fdata.replace('@PROJECT_SOURCE_DIR@', '.') | ||
with open('./docs/doxygen/Doxyfile.in', 'w') as f: | ||
f.write(fdata) | ||
with open('./docs/doxygen/Doxyfile.in', 'a') as f: | ||
f.write("\nOUTPUT_DIRECTORY=./_build/html/doxygen") | ||
f.write("\nOUTPUT_DIRECTORY=../_readthedocs/html/doxygen") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR by ReadtheDocs introduced the change, and will likely impact most github projects using doxygen on ReadTheDocs:
readthedocs/readthedocs.org#9888
Doxygen generation broken in latest RAJA:
https://raja.readthedocs.io/en/develop/doxygen/html/index.html
The breaking change in their PR was renaming the hosted output directory from ./_build/html/...
to ./_readthedocs/html/...
Seems like alot of projects are dependent on this _build
directory:
https://github.com/search?q=filename%3Aconf.py+doxygen+%26%26+_build&type=Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmhan12 Thanks for pointing this out.
This PR:
srun
callsflux mini run
underneath. Issue last week was flux wrappers not being initialized by default on the system after updates.