Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V0.8.0 rc #1145

Merged
merged 1,370 commits into from
Jul 26, 2023
Merged

V0.8.0 rc #1145

merged 1,370 commits into from
Jul 26, 2023

Conversation

rhornung67
Copy link
Member

@rhornung67 rhornung67 commented Jul 24, 2023 •
edited
Loading

Summary

  • This PR is to move all work on develop to main for v0.8.0 release.
  • Since almost all changes have been approved and merged into develop, please approve this PR since it will be merged, but review the other PR that contains only changes to develop: v0.8.0 release prep changes for review #1146

@bmhan12
Add Pro/E option to loadShape()
81ff869
@bmhan12
WIP - separate out Pro/E and c2c workflow
8e832c4
@bmhan12
sanity Pro/E mesh output
fc283fb
@bmhan12
Add compute bounding box overload for tetrahedron
daafa84
@bmhan12
WIP - setup tet mesh
253d72d
@bmhan12
Post merge changes - filterMesh() operation for c2c guard
a3def93
@bmhan12
WIP - runShapeQuery equivalent for proe
d8caa1d
@bmhan12
IndexType over int
48882cd
@bmhan12
Check file format and file type before reading
100fce7
@bmhan12
Check for duplicate vertices in valid polyhedron check; add special t…
93fe2fe 
…est case for clipping
@bmhan12
WIP - move format check inside IntersectionShaper class instead of at…
66813c3 
… the driver level
@bmhan12
Add mixed proe/c2c unit test case
129b16f
@bmhan12
Add proe-only test case with baseline
0eb779d
@bmhan12
Properly guard the new proe tests in non-RAJA, non-Umpire case
fd260c0
@bmhan12
Refactoring of prepareShapeQuery
67c9f8c
@bmhan12
Use ArrayView over pointer copies
eda9dcc
@bmhan12
Refactor runShapeQuery; make NUM_VERTS standard between Octs and Tets
4ce4d77
@bmhan12
Cleanup
917ed8f
@bmhan12
Put duplicate vertices check into kernel body to remove warning; bugf…
f42abd0 
…ix wrong count
@bmhan12
Unused
f263fd1
@bmhan12
Make hasDuplicateVertices() function standalone with tolerance, remov…
50d2d43 
…e duplicate logic in driver
@bmhan12
Convert bounding boxes and hexes to Array
811a52b
@bmhan12
Additional Array refactoring, but hanging on rzvernal...
c843ec6
@bmhan12
Leave troublesome allocations as ptrs instead of Arrays
72bfd43
@bmhan12
Refactor oct/tet members to use Array, refactor Discretize functions …
7cb0d8a 
…to use Array to accomodate changes
@bmhan12
Workaround changes for gcc@8.1.0 compiler
d340e93
@bmhan12
Update notes
b2a7b1b
@bmhan12
Wordsmithing
d799f4d
@bmhan12
smithing, consistent style
f4c1907
@bmhan12
Workaround for marching cubes for gcc@8.1.0~fortran compiler
dc5bd9e
bmhan12 and others added 3 commits July 21, 2023 10:35
@rhornung67 rhornung67 mentioned this pull request Jul 24, 2023
Closed
white238
white238 reviewed Jul 24, 2023
View reviewed changes
src/cmake/AxomVersion.cmake
@@ -1,4 +1,4 @@
# Copyright (c) 2017-2022, Lawrence Livermore National Security, LLC and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a version change in this file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. You're too fast for me!

@rhornung67
Copy link
Member Author

Folks, can we get some eyeballs on this so we can put out the release today or tomorrow? Multiple codes are asking for it.

bmhan12
bmhan12 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@bmhan12 bmhan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BradWhitlock should be added to the .mailmap and CITATION.cff files

@rhornung67
Copy link
Member Author

@BradWhitlock should be added to the .mailmap and CITATION.cff files

Done.

@rhornung67
Copy link
Member Author

To be honest, I don't understand how the various entries in the mailmap file get generated. It looks like a combination of manual entry and automation.

@white238
Copy link
Member

To be honest, I don't understand how the various entries in the mailmap file get generated. It looks like a combination of manual entry and automation.

It's me. I periodically look at our git log of authors and add new entries to the mailmap file to combine them.

@rhornung67
Copy link
Member Author

So a lot of the entries reference accounts on old LC machines that no longer exist (e.g., cab). Should those be culled out?

@white238
Copy link
Member

white238 commented Jul 25, 2023 •
edited
Loading

So a lot of the entries reference accounts on old LC machines that no longer exist (e.g., cab). Should those be culled out?

No, these are entries from the git author log that need to be merged to the real email of the person. The left side is the correct one, the right is the extra email or name that isnt quite right but has a commit with that author/email combo.

This should not hold up the release. It really isn't important. It just cleans up our git log.

@rhornung67
Copy link
Member Author

I'll merge this and push out the release tomorrow morning. If anyone wants to take a look at it, please do it before tomorrow.

@rhornung67 rhornung67 merged commit 71fab32 into main Jul 26, 2023
10 checks passed
@rhornung67 rhornung67 deleted the v0.8.0-RC branch July 26, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@white238 white238 white238 approved these changes

@agcapps agcapps agcapps approved these changes

@bmhan12 bmhan12 bmhan12 approved these changes

@cyrush cyrush Awaiting requested review from cyrush

@BradWhitlock BradWhitlock Awaiting requested review from BradWhitlock

@kennyweiss kennyweiss Awaiting requested review from kennyweiss

@nselliott nselliott Awaiting requested review from nselliott

@publixsubfan publixsubfan Awaiting requested review from publixsubfan

@ltaylor16 ltaylor16 Awaiting requested review from ltaylor16

@gunney1 gunney1 Awaiting requested review from gunney1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rhornung67 @white238 @agcapps @bmhan12 @kennyweiss @gunney1 @jcs15c