Add 3D tests for DistributedClosestPoints #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyweiss
reviewed
Feb 5, 2024
There was a problem hiding this comment.
This is looking nice @gunney1 -- if it's not too difficult, could you please post a screenshot and perhaps some performance stats (e.g. cpu vs. gpu vs. openmp) when they're ready?
rhornung67
reviewed
Feb 5, 2024
rhornung67
reviewed
Feb 5, 2024
| }; | ||
|
|
||
| // Output some global mesh size stats | ||
| { |
There was a problem hiding this comment.
Is it preferable to define each of these in a separate scope or reuse/rename the local variables?
There was a problem hiding this comment.
The scope makes it clear that they're temporary variables, but reusing variables would shorten the code by a few lines.
rhornung67
reviewed
Feb 5, 2024
gunney1
requested review from
kennyweiss,
rhornung67,
publixsubfan,
agcapps and
bmhan12
rhornung67
approved these changes
Feb 5, 2024
kennyweiss
approved these changes
Feb 6, 2024
agcapps
reviewed
Feb 6, 2024
src/axom/quest/examples/quest_distributed_distance_query_example.cpp
Outdated
Show resolved
Hide resolved
agcapps
reviewed
Feb 6, 2024
src/axom/quest/examples/quest_distributed_distance_query_example.cpp
Outdated
Show resolved
Hide resolved
agcapps
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 3D tests for
DistributedClosestPointsquest_distributed_distance_query_example.cppto accomodate 3D meshes.Images from the 3D tests follow. Some of the object points lie outside the query mesh, so their colors aren't faded from the opacity of the mesh. The problem had a distance threshold of 0.3.
This PR resolves #910