Add options to customize execute_experiment.tpl #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
experiment
|
@jdomke I'm curious if this PR addresses your needs |
scheibelp
changed the title
from a quick look at it, it seems to be doing what i needed, but i have not tried it, do you need me to verify it before you merge, or should i wait until after and debug if necessary? |
Whichever you prefer: it sounds like you are fine with it being merged before you get a chance to test it, so I'll proceed with that assumption unless you say otherwise. |
scheibelp
changed the title
pearce8
approved these changes
Jun 25, 2024
daboehme
pushed a commit
that referenced
this pull request
Jul 10, 2024
* show example of not using allocation modifier * restore test config * I was hoping I could expand variables into lists; but I don't think that will work * variable naming consistency * refactor as multi-line strings vs string lists * add test config; demonstrates an odd behavior for expansion of multi-line strings * expand test config * needed for emulating #258 * missing space * style fix * style fix 2 * forgot to re-add argument with new format * relocate execute_experiment template
scheibelp
added a commit
that referenced
this pull request
Jul 26, 2024
scheibelp
added a commit
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #258
New variables supported in
variables.yaml:extra_cmd_opts: These appear as extra options tompirun,srun, or whatever exec cmd is chosen byscheduler. Newlines can be used for organization, but are removed ("-x 1\n-y 2"becomesmpirun -x 1 -y 2 ...)extra_batch_opts: This appear as batch directive lines at the top of the scriptpost_exec_cmds: inserted verbatim after the exec (whatever the main experiment binary is run)pre_exec_cmds: likepost_..., but before the experiment runsThis also provides a means to define a system or experiment-specific
execute_experiment.tpl. The experiment can likewise choose to omit theallocationmodifier, and thereby specify everything manually