Feature/new modifier implementation #356
Conversation
github-actions
bot
added
experiment
| ) | ||
| elif self.spec.satisfies("caliper=cuda"): | ||
| cuda_support = ( | ||
| self.spec.satisfies("caliper=cuda") and True |
There was a problem hiding this comment.
and True looks vestigial
| # set package spack specs | ||
| package_specs = {} | ||
|
|
||
| if not self.spec.satisfies("caliper=none"): |
There was a problem hiding this comment.
I get the impression that some combinations of caliper=... are not allowed. I don't know if we support conflict yet, but FWIW you can raise an exception here for forbidden combinations.
| from benchpark.experiment import Experiment | ||
|
|
||
|
|
||
| class Caliper(Experiment): |
There was a problem hiding this comment.
I think the failure at https://github.com/LLNL/benchpark/actions/runs/11446987606/job/31847369138?pr=356 will be resolved if you make it so that caliper does not inherit Experiment (which I think is what you wanted to do). If that doesn't work I'll likely have to investigate it (but that failure in the dry runs does in fact look legitimate, so we'll want to address it before merging this).
There was a problem hiding this comment.
This coulda also be addressed by undoing 2a0a077 I think (the part that rearranges the order of declared superclasses)
New modifier implementation using experiment.py