Added two new tests #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imply saves a toy model to a temporary file, then checks to make sure its valid. Also added a test to ensure the available model keys in model.py match what's in the data directory in popclass
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Issue #25. simply adding test coverage to ensure IO capabilities for population models and ensuring consistency between the model libraries parameters in popclass and the data stored in the project.
Description of the Change
One to test the ASDF IO for population models. Simply saves a toy model to a temporary file, then checks to make sure its valid. Also added a test to ensure the available model keys in model.py match what's in the data directory in popclass
Also, fixed a small typo in model.py.
Checklist
Please check all that apply to your proposed changes
Additional context