Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some lists expanded wrong #32

Open
abrekhov opened this issue Jan 15, 2021 · 1 comment · May be fixed by #35
Open

Some lists expanded wrong #32

abrekhov opened this issue Jan 15, 2021 · 1 comment · May be fixed by #35

Comments

@abrekhov
Copy link

Function expand for host list is not correct. E.g. s02p[017,029-030] gives 's02p17,s02p29,s02p30'.
@morenodelgad1
Copy link
Member

morenodelgad1 commented Dec 20, 2021 •
edited
Loading

This was remedied in the last merge request: 8ace7a6

Correction: The merge request listed above has some of the code, not all of it. Will update the package on PyPI in the coming weeks.

Only about a year late to your comment.

cmoussa1 added a commit to cmoussa1/py-hostlist that referenced this issue Sep 4, 2024
@cmoussa1
expand(): correct leading zeros issue
bd10ce1 
Problem: As noted in LLNL#32, the expand() function doesn't correctly
handle hostlists with leading zeros in the ranges.

Rework and restructure the expand() function to correctly handle ranges
of leading zeros, particularly when there are multiple ranges.

Add a unit test using the example provided in LLNL#32 to confirm it is
working as expected.
cmoussa1 added a commit to cmoussa1/py-hostlist that referenced this issue Sep 4, 2024
@cmoussa1
expand(): correct leading zeros issue
5ada2d5 
Problem: As noted in LLNL#32, the expand() function doesn't correctly
handle hostlists with leading zeros in the ranges.

Rework and restructure the expand() function to correctly handle ranges
of leading zeros, particularly when there are multiple ranges.

Add a unit test using the example provided in LLNL#32 to confirm it is
working as expected.
@cmoussa1 cmoussa1 linked a pull request Sep 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expand(): handle case of multiple ranges with leading zeros cmoussa1/py-hostlist
2 participants
@abrekhov @morenodelgad1